mstoeck3/autopsy-flatpak
1
0
Fork 0
mirror of https://github.com/overcuriousity/autopsy-flatpak.git synced 2025-07-12 16:06:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove JFX dependency in TSK

Browse Source
This commit is contained in:
Richard Cordovano 2019-12-04 20:11:50 -05:00
parent 56f1bff881
commit f3f7d052e6
2 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Core/src/org/sleuthkit/autopsy/timeline/EventsModel.java
View File

@ -181,9 +181,6 @@ public final class EventsModel {
/* /*
* Initialize the events filter state model parameter with the default * Initialize the events filter state model parameter with the default
* events filter. * events filter.
*
* RJCTODO: Why isn't the event filter state of the initialModelParams
* used here?
*/ */
filterStateProperty.set(getDefaultEventFilterState()); filterStateProperty.set(getDefaultEventFilterState());
@ -223,12 +220,9 @@ public final class EventsModel {
* Adds a data source filter for each data source in the data sources cache * Adds a data source filter for each data source in the data sources cache
* to a given root filter state object. * to a given root filter state object.
* *
* RJCTODO: This method should be synchronized! RJCTODO: This seems like an
* unusual method.
*
* @param rootFilterState A root filter state object. * @param rootFilterState A root filter state object.
*/ */
void addDataSourceFilters(RootFilterState rootFilterState) { synchronized void addDataSourceFilters(RootFilterState rootFilterState) {
DataSourcesFilter dataSourcesFilter = rootFilterState.getDataSourcesFilterState().getFilter(); DataSourcesFilter dataSourcesFilter = rootFilterState.getDataSourcesFilterState().getFilter();
datasourceIDsToNamesMap.entrySet().forEach(entry -> dataSourcesFilter.addSubFilter(newDataSourceFilter(entry))); datasourceIDsToNamesMap.entrySet().forEach(entry -> dataSourcesFilter.addSubFilter(newDataSourceFilter(entry)));
} }
@ -238,9 +232,6 @@ public final class EventsModel {
* counts are organized by event type for the given event types hierarchy * counts are organized by event type for the given event types hierarchy
* level. * level.
* *
* RJCTODO: Where does the argument for this method come from when called by
* the cache builder?
*
* @param modelParams The model parameters. * @param modelParams The model parameters.
* *
* @return A mapping of event types to event counts at the given event types * @return A mapping of event types to event counts at the given event types
@ -787,10 +778,6 @@ public final class EventsModel {
* in which case only the corresponding entries in the event IDs cache are * in which case only the corresponding entries in the event IDs cache are
* invalidated. * invalidated.
* *
* RJCTODO: What is the use case for passing event IDs? The only place this
* is currently done is when handling TIMELINE_EVENT_ADDED events, i.e., for
* entirely new events. Is this some sort of performance optimization?
*
* @param updatedEventIDs Either null or a collection of the event IDs. * @param updatedEventIDs Either null or a collection of the event IDs.
* *
* @throws TskCoreException * @throws TskCoreException

3
Core/src/org/sleuthkit/autopsy/timeline/ui/filtering/datamodel/FilterState.java
View File

@ -56,8 +56,7 @@ public interface FilterState<FilterType> {
FilterType getActiveFilter(); FilterType getActiveFilter();
/** /**
* Makes a deep copy of this filter state object. // RJCTODO: Is it really a * Makes a deep copy of this filter state object.
* deep copy?
* *
* @return The copy. * @return The copy.
*/ */