From f3f7d052e66f56e5c2c390366ff3ce4cce06ef0c Mon Sep 17 00:00:00 2001
From: Richard Cordovano <rcordovano@basistech.com>
Date: Wed, 4 Dec 2019 20:11:50 -0500
Subject: [PATCH] Remove JFX dependency in TSK

---
 .../sleuthkit/autopsy/timeline/EventsModel.java   | 15 +--------------
 .../ui/filtering/datamodel/FilterState.java       |  3 +--
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/Core/src/org/sleuthkit/autopsy/timeline/EventsModel.java b/Core/src/org/sleuthkit/autopsy/timeline/EventsModel.java
index c47d52b62d..e30c266b03 100755
--- a/Core/src/org/sleuthkit/autopsy/timeline/EventsModel.java
+++ b/Core/src/org/sleuthkit/autopsy/timeline/EventsModel.java
@@ -181,9 +181,6 @@ public final class EventsModel {
         /*
          * Initialize the events filter state model parameter with the default
          * events filter.
-         *
-         * RJCTODO: Why isn't the event filter state of the initialModelParams
-         * used here?
          */
         filterStateProperty.set(getDefaultEventFilterState());
 
@@ -223,12 +220,9 @@ public final class EventsModel {
      * Adds a data source filter for each data source in the data sources cache
      * to a given root filter state object.
      *
-     * RJCTODO: This method should be synchronized! RJCTODO: This seems like an
-     * unusual method.
-     *
      * @param rootFilterState A root filter state object.
      */
-    void addDataSourceFilters(RootFilterState rootFilterState) {
+    synchronized void addDataSourceFilters(RootFilterState rootFilterState) {
         DataSourcesFilter dataSourcesFilter = rootFilterState.getDataSourcesFilterState().getFilter();
         datasourceIDsToNamesMap.entrySet().forEach(entry -> dataSourcesFilter.addSubFilter(newDataSourceFilter(entry)));
     }
@@ -238,9 +232,6 @@ public final class EventsModel {
      * counts are organized by event type for the given event types hierarchy
      * level.
      *
-     * RJCTODO: Where does the argument for this method come from when called by
-     * the cache builder?
-     *
      * @param modelParams The model parameters.
      *
      * @return A mapping of event types to event counts at the given event types
@@ -787,10 +778,6 @@ public final class EventsModel {
      * in which case only the corresponding entries in the event IDs cache are
      * invalidated.
      *
-     * RJCTODO: What is the use case for passing event IDs? The only place this
-     * is currently done is when handling TIMELINE_EVENT_ADDED events, i.e., for
-     * entirely new events. Is this some sort of performance optimization?
-     *
      * @param updatedEventIDs Either null or a collection of the event IDs.
      *
      * @throws TskCoreException
diff --git a/Core/src/org/sleuthkit/autopsy/timeline/ui/filtering/datamodel/FilterState.java b/Core/src/org/sleuthkit/autopsy/timeline/ui/filtering/datamodel/FilterState.java
index 4ee2a2facc..5dfd7c8066 100755
--- a/Core/src/org/sleuthkit/autopsy/timeline/ui/filtering/datamodel/FilterState.java
+++ b/Core/src/org/sleuthkit/autopsy/timeline/ui/filtering/datamodel/FilterState.java
@@ -56,8 +56,7 @@ public interface FilterState<FilterType> {
     FilterType getActiveFilter();
 
     /**
-     * Makes a deep copy of this filter state object. // RJCTODO: Is it really a
-     * deep copy?
+     * Makes a deep copy of this filter state object.
      *
      * @return The copy.
      */