From fd5cc7cb1694bcceb191aa80b9bdf9293f5d23ed Mon Sep 17 00:00:00 2001
From: Richard Cordovano <rcordovano@basistech.com>
Date: Sat, 14 Mar 2020 11:32:47 -0400
Subject: [PATCH] Improve performance of set display name for
 BlackboardArtifactNode

---
 .../datamodel/BlackboardArtifactNode.java     | 48 +------------------
 1 file changed, 2 insertions(+), 46 deletions(-)

diff --git a/Core/src/org/sleuthkit/autopsy/datamodel/BlackboardArtifactNode.java b/Core/src/org/sleuthkit/autopsy/datamodel/BlackboardArtifactNode.java
index caa2481a4c..b4aafc2bcc 100644
--- a/Core/src/org/sleuthkit/autopsy/datamodel/BlackboardArtifactNode.java
+++ b/Core/src/org/sleuthkit/autopsy/datamodel/BlackboardArtifactNode.java
@@ -207,6 +207,7 @@ public class BlackboardArtifactNode extends AbstractContentNode<BlackboardArtifa
      * @param artifact The artifact to represent.
      * @param iconPath The path to the icon for the artifact type.
      */
+    @NbBundle.Messages({"# {0} - artifactDisplayName", "BlackboardArtifactNode.displayName.artifact={0} Artifact"})    
     public BlackboardArtifactNode(BlackboardArtifact artifact, String iconPath) {
         super(artifact, createLookup(artifact));
         this.artifact = artifact;
@@ -228,7 +229,7 @@ public class BlackboardArtifactNode extends AbstractContentNode<BlackboardArtifa
             }
         }
         setName(Long.toString(artifact.getArtifactID()));
-        setDisplayName();
+        setDisplayName(Bundle.BlackboardArtifactNode_displayName_artifact(artifact.getDisplayName()));
         setIconBaseWithExtension(iconPath);
         Case.addEventTypeSubscriber(CASE_EVENTS_OF_INTEREST, weakAppEventListener);
     }
@@ -266,51 +267,6 @@ public class BlackboardArtifactNode extends AbstractContentNode<BlackboardArtifa
         }
     }
 
-    /**
-     * Sets the display name for this node.
-     */
-    @NbBundle.Messages({"# {0} - artifactDisplayName", "BlackboardArtifactNode.displayName.artifact={0} Artifact"})
-    private void setDisplayName() {
-        String displayName = ""; //NON-NLS
-
-        /*
-         * If the artifact this node represents is a keyword hit artifact and
-         * the associated artifact can be retreived from the case database, make
-         * the display name the display name of the associated artifact.
-         *
-         * If the artifact this node represents is an interesting artifact hit
-         * and the associated artifact can be retreived from the case database,
-         * make the display name the display name of the artifact this node
-         * represents.
-         */
-        if (artifact != null
-                && (artifact.getArtifactTypeID() == ARTIFACT_TYPE.TSK_KEYWORD_HIT.getTypeID()
-                || artifact.getArtifactTypeID() == ARTIFACT_TYPE.TSK_INTERESTING_ARTIFACT_HIT.getTypeID())) {
-            try {
-                for (BlackboardAttribute attribute : artifact.getAttributes()) {
-                    if (attribute.getAttributeType().getTypeID() == ATTRIBUTE_TYPE.TSK_ASSOCIATED_ARTIFACT.getTypeID()) {
-                        BlackboardArtifact associatedArtifact = Case.getCurrentCaseThrows().getSleuthkitCase().getBlackboardArtifact(attribute.getValueLong());
-                        if (associatedArtifact != null) {
-                            if (artifact.getArtifactTypeID() == ARTIFACT_TYPE.TSK_INTERESTING_ARTIFACT_HIT.getTypeID()) {
-                                displayName = Bundle.BlackboardArtifactNode_displayName_artifact(artifact.getDisplayName());
-                            } else {
-                                displayName = Bundle.BlackboardArtifactNode_displayName_artifact(associatedArtifact.getDisplayName());
-                            }
-                        }
-                    }
-                }
-            } catch (TskCoreException | NoCurrentCaseException ex) {
-                logger.log(Level.SEVERE, MessageFormat.format("Error getting associated artifact of TSK_KEYWORD_HIT/TSK_INTERESTING_ARTIFACT_HIT artifact (objID={0}))", artifact.getId()), ex); //NON-NLS
-            }
-        }
-
-        if (displayName.isEmpty() && artifact != null) {
-            displayName = artifact.getDisplayName();
-        }
-
-        setDisplayName(displayName);
-    }
-
     /**
      * Unregisters the application event listener when this node is garbage
      * collected, if this finalizer is actually called.