fix for codacy and commenting issues

This commit is contained in:
Greg DiCristofaro 2020-06-02 11:58:35 -04:00
parent 1ade5a4f34
commit fc01fcd48d
4 changed files with 3 additions and 11 deletions

View File

@ -50,9 +50,6 @@ import org.sleuthkit.autopsy.coreutils.MessageNotifyUtil;
import org.sleuthkit.autopsy.coreutils.ThreadConfined; import org.sleuthkit.autopsy.coreutils.ThreadConfined;
import org.sleuthkit.autopsy.geolocation.GeoFilterPanel.GeoFilter; import org.sleuthkit.autopsy.geolocation.GeoFilterPanel.GeoFilter;
import org.sleuthkit.autopsy.geolocation.datamodel.GeoLocationDataException; import org.sleuthkit.autopsy.geolocation.datamodel.GeoLocationDataException;
import org.sleuthkit.autopsy.geolocation.datamodel.GeoLocationParseResult;
import org.sleuthkit.autopsy.geolocation.datamodel.Track;
import org.sleuthkit.autopsy.geolocation.datamodel.Waypoint;
import org.sleuthkit.autopsy.ingest.IngestManager; import org.sleuthkit.autopsy.ingest.IngestManager;
import static org.sleuthkit.autopsy.ingest.IngestManager.IngestModuleEvent.DATA_ADDED; import static org.sleuthkit.autopsy.ingest.IngestManager.IngestModuleEvent.DATA_ADDED;
import org.sleuthkit.autopsy.ingest.ModuleDataEvent; import org.sleuthkit.autopsy.ingest.ModuleDataEvent;

View File

@ -23,12 +23,12 @@ import java.util.List;
import org.python.google.common.collect.ImmutableList; import org.python.google.common.collect.ImmutableList;
/** /**
* The result of attempting to parse a GeoLocation object. * The result of attempting to parse GeoLocation objects.
*/ */
public class GeoLocationParseResult<T> { public class GeoLocationParseResult<T> {
private boolean successfullyParsed; private boolean successfullyParsed;
private List<T> items = new ArrayList<>(); private final List<T> items = new ArrayList<>();
/** /**
* Returns a GeoLocationParseResult with no items and declared successfully * Returns a GeoLocationParseResult with no items and declared successfully
@ -61,10 +61,7 @@ public class GeoLocationParseResult<T> {
* @param toAdd The GeoLocationParseResult to add. * @param toAdd The GeoLocationParseResult to add.
*/ */
public void add(GeoLocationParseResult<T> toAdd) { public void add(GeoLocationParseResult<T> toAdd) {
this.successfullyParsed = (this.successfullyParsed == false) this.successfullyParsed = this.successfullyParsed && toAdd.isSuccessfullyParsed();
? false
: toAdd.isSuccessfullyParsed();
this.items.addAll(toAdd.getItems()); this.items.addAll(toAdd.getItems());
} }

View File

@ -25,7 +25,6 @@ import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import java.util.logging.Level; import java.util.logging.Level;
import java.util.stream.Collectors;
import org.sleuthkit.autopsy.coreutils.Logger; import org.sleuthkit.autopsy.coreutils.Logger;
import org.sleuthkit.datamodel.BlackboardArtifact; import org.sleuthkit.datamodel.BlackboardArtifact;
import org.sleuthkit.datamodel.BlackboardArtifact.ARTIFACT_TYPE; import org.sleuthkit.datamodel.BlackboardArtifact.ARTIFACT_TYPE;

View File

@ -33,7 +33,6 @@ import java.io.OutputStream;
import java.nio.file.Path; import java.nio.file.Path;
import java.nio.file.Paths; import java.nio.file.Paths;
import java.text.SimpleDateFormat; import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.logging.Level; import java.util.logging.Level;
import java.util.stream.Collectors; import java.util.stream.Collectors;