Removed EDT db calls from GetTagNameDialog

Core/src/org/sleuthkit/autopsy/actions/Bundle.properties-MERGED

@@ -1,18 +1,24 @@
 AddBlackboardArtifactTagAction.pluralTagResult=Add Result Tags
 AddBlackboardArtifactTagAction.singularTagResult=Add Result Tag
 AddBlackboardArtifactTagAction.taggingErr=Tagging Error
+# {0} - artifactName
 AddBlackboardArtifactTagAction.unableToTag.msg=Unable to tag {0}.
 AddContentTagAction.cannotApplyTagErr=Cannot Apply Tag
 AddContentTagAction.pluralTagFile=Add File Tags
 AddContentTagAction.singularTagFile=Add File Tag
+# {0} - fileName
+# {1} - tagName
 AddContentTagAction.tagExists={0} has been tagged as {1}. Cannot reapply the same tag.
 AddContentTagAction.taggingErr=Tagging Error
+# {0} - fileName
 AddContentTagAction.unableToTag.msg=Unable to tag {0}, not a regular file.
+# {0} - fileName
 AddContentTagAction.unableToTag.msg2=Unable to tag {0}.
 CTL_DumpThreadAction=Thread Dump
 CTL_ShowIngestProgressSnapshotAction=Ingest Status Details
 DeleteBlackboardArtifactTagAction.deleteTag=Remove Selected Tag(s)
 DeleteBlackboardArtifactTagAction.tagDelErr=Tag Deletion Error
+# {0} - tagName
 DeleteBlackboardArtifactTagAction.unableToDelTag.msg=Unable to delete tag {0}.
 DeleteContentTagAction.deleteTag=Remove Selected Tag(s)
 DeleteContentTagAction.tagDelErr=Tag Deletion Error
@@ -78,6 +84,8 @@ CTL_OpenOutputFolder=Open Case Folder
 OpenOutputFolder.error1=Case Folder Not Found: {0}
 OpenOutputFolder.noCaseOpen=No open case, therefore no current case folder available.
 OpenOutputFolder.CouldNotOpenOutputFolder=Could not open case folder 
+# {0} - old tag name
+# {1} - artifactID
 ReplaceBlackboardArtifactTagAction.replaceTag.alert=Unable to replace tag {0} for artifact {1}.
 # {0} - old tag name
 # {1} - content obj id

Core/src/org/sleuthkit/autopsy/actions/GetTagNameDialog.java

@@ -18,6 +18,7 @@
  */
 package org.sleuthkit.autopsy.actions;
 
+import java.awt.Cursor;
 import java.awt.Window;
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
@@ -25,6 +26,7 @@ import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
+import java.util.concurrent.ExecutionException;
 import java.util.logging.Level;
 import javax.swing.AbstractAction;
 import javax.swing.ActionMap;
@@ -33,7 +35,9 @@ import javax.swing.JComponent;
 import javax.swing.JDialog;
 import javax.swing.JOptionPane;
 import javax.swing.KeyStroke;
+import javax.swing.SwingWorker;
 import javax.swing.table.AbstractTableModel;
+import org.openide.util.Exceptions;
 import org.openide.util.ImageUtilities;
 import org.openide.util.NbBundle;
 import org.openide.util.NbBundle.Messages;
@@ -163,7 +167,50 @@ public class GetTagNameDialog extends JDialog {
             return tagDisplayNames.get(rowIndex);
         }
     }
+    
+    /**
+     * A SwingWorker for creating a new TagName.
+     */
+    private class AddTagNameWorker extends SwingWorker<TagName, Void> {
 
+        private final String name;
+        private final String description;
+        private final TskData.FileKnown status;
+        private final TagName.HTML_COLOR color;
+        
+        AddTagNameWorker(String name, String description, TskData.FileKnown status, TagName.HTML_COLOR color) {
+            this.name = name;
+            this.description = description;
+            this.status = status;
+            this.color = color;
+        }
+        
+        @Override
+        protected TagName doInBackground() throws Exception {
+            return Case.getCurrentCaseThrows().getServices().getTagsManager().addTagName(name, description, color, status);
+        }
+        
+        @Override 
+        protected void done() {            
+            try {
+                tagName = get();
+                dispose();
+            } catch (ExecutionException | InterruptedException ex) {
+                Logger.getLogger(AddTagAction.class.getName()).log(Level.SEVERE, "Error adding " + name + " tag name", ex); //NON-NLS
+                    JOptionPane.showMessageDialog(GetTagNameDialog.this,
+                            NbBundle.getMessage(GetTagNameDialog.this.getClass(),
+                                    "GetTagNameDialog.unableToAddTagNameToCase.msg",
+                                    name),
+                            NbBundle.getMessage(this.getClass(), "GetTagNameDialog.taggingErr"),
+                            JOptionPane.ERROR_MESSAGE);
+                tagName = null;
+            } 
+            
+            okButton.setEnabled(true);
+            cancelButton.setEnabled(true);
+            setCursor(Cursor.getPredefinedCursor(Cursor.DEFAULT_CURSOR));
+        } 
+    }
     /**
      * This method is called from within the constructor to initialize the form.
      * WARNING: Do NOT modify this code. The content of this method is always
@@ -351,32 +398,12 @@ public class GetTagNameDialog extends JDialog {
             tagName = tagNamesMap.get(tagDisplayName);
 
             if (tagName == null) {
-                try {
+                AddTagNameWorker worker = new AddTagNameWorker(tagDisplayName, userTagDescription, status, TagName.HTML_COLOR.NONE );
-                    tagName = Case.getCurrentCaseThrows().getServices().getTagsManager().addTagName(tagDisplayName, userTagDescription, TagName.HTML_COLOR.NONE, status);
+                okButton.setEnabled(false);
-                    dispose();
+                cancelButton.setEnabled(false);
-                } catch (TskCoreException | NoCurrentCaseException ex) {
+                setCursor(Cursor.getPredefinedCursor(Cursor.WAIT_CURSOR));
-                    Logger.getLogger(AddTagAction.class.getName()).log(Level.SEVERE, "Error adding " + tagDisplayName + " tag name", ex); //NON-NLS
+                
-                    JOptionPane.showMessageDialog(this,
+                worker.execute();
-                            NbBundle.getMessage(this.getClass(),
-                                    "GetTagNameDialog.unableToAddTagNameToCase.msg",
-                                    tagDisplayName),
-                            NbBundle.getMessage(this.getClass(), "GetTagNameDialog.taggingErr"),
-                            JOptionPane.ERROR_MESSAGE);
-                    tagName = null;
-                } catch (TagsManager.TagNameAlreadyExistsException ex) {
-                    try {
-                        tagName = Case.getCurrentCaseThrows().getServices().getTagsManager().getDisplayNamesToTagNamesMap().get(tagDisplayName);
-                    } catch (TskCoreException | NoCurrentCaseException ex1) {
-                        Logger.getLogger(AddTagAction.class.getName()).log(Level.SEVERE, tagDisplayName + " exists in database but an error occurred in retrieving it.", ex1); //NON-NLS
-                        JOptionPane.showMessageDialog(this,
-                                NbBundle.getMessage(this.getClass(),
-                                        "GetTagNameDialog.tagNameExistsTskCore.msg",
-                                        tagDisplayName),
-                                NbBundle.getMessage(this.getClass(), "GetTagNameDialog.dupTagErr"),
-                                JOptionPane.ERROR_MESSAGE);
-                        tagName = null;
-                    }
-                }
             } else {
                 JOptionPane.showMessageDialog(this,
                         NbBundle.getMessage(this.getClass(), "GetTagNameDialog.tagNameAlreadyExists.message"),