Merge pull request #2098 from BasisOlivers/aut-1663

Added exception logging to image extraction code.
This commit is contained in:
Richard Cordovano 2016-05-04 14:48:19 -04:00
commit e9ad75a93b

View File

@ -150,7 +150,7 @@ class ImageExtractor {
} }
} }
} catch (TskCoreException e) { } catch (TskCoreException e) {
logger.log(Level.INFO, "Error checking if file already has been processed, skipping: {0}", parentFileName); //NON-NLS logger.log(Level.WARNING, String.format("Error checking if file already has been processed, skipping: %s", parentFileName), e); //NON-NLS
return; return;
} }
switch (abstractFileExtractionFormat) { switch (abstractFileExtractionFormat) {
@ -209,21 +209,21 @@ class ImageExtractor {
HWPFDocument doc = null; HWPFDocument doc = null;
try { try {
doc = new HWPFDocument(new ReadContentInputStream(af)); doc = new HWPFDocument(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.docContainer.init.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.docContainer.init.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
PicturesTable pictureTable = null; PicturesTable pictureTable = null;
List<org.apache.poi.hwpf.usermodel.Picture> listOfAllPictures = null; List<org.apache.poi.hwpf.usermodel.Picture> listOfAllPictures = null;
try { try {
pictureTable = doc.getPicturesTable(); pictureTable = doc.getPicturesTable();
listOfAllPictures = pictureTable.getAllPictures(); listOfAllPictures = pictureTable.getAllPictures();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
String outputFolderPath; String outputFolderPath;
@ -241,9 +241,9 @@ class ImageExtractor {
String fileName = picture.suggestFullFileName(); String fileName = picture.suggestFullFileName();
try { try {
data = picture.getContent(); data = picture.getContent();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data);
@ -267,18 +267,18 @@ class ImageExtractor {
XWPFDocument docx = null; XWPFDocument docx = null;
try { try {
docx = new XWPFDocument(new ReadContentInputStream(af)); docx = new XWPFDocument(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.docxContainer.init.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.docxContainer.init.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
List<XWPFPictureData> listOfAllPictures = null; List<XWPFPictureData> listOfAllPictures = null;
try { try {
listOfAllPictures = docx.getAllPictures(); listOfAllPictures = docx.getAllPictures();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
// if no images are extracted from the PPT, return null, else initialize // if no images are extracted from the PPT, return null, else initialize
@ -299,9 +299,9 @@ class ImageExtractor {
String fileName = xwpfPicture.getFileName(); String fileName = xwpfPicture.getFileName();
try { try {
data = xwpfPicture.getData(); data = xwpfPicture.getData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data);
@ -323,9 +323,9 @@ class ImageExtractor {
SlideShow ppt = null; SlideShow ppt = null;
try { try {
ppt = new SlideShow(new ReadContentInputStream(af)); ppt = new SlideShow(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.pptContainer.init.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.pptContainer.init.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
@ -333,10 +333,10 @@ class ImageExtractor {
PictureData[] listOfAllPictures = null; PictureData[] listOfAllPictures = null;
try { try {
listOfAllPictures = ppt.getPictureData(); listOfAllPictures = ppt.getPictureData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
// if no images are extracted from the PPT, return null, else initialize // if no images are extracted from the PPT, return null, else initialize
@ -385,9 +385,9 @@ class ImageExtractor {
String imageName = UNKNOWN_NAME_PREFIX + i + ext; //NON-NLS String imageName = UNKNOWN_NAME_PREFIX + i + ext; //NON-NLS
try { try {
data = pictureData.getData(); data = pictureData.getData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data);
@ -410,18 +410,18 @@ class ImageExtractor {
XMLSlideShow pptx; XMLSlideShow pptx;
try { try {
pptx = new XMLSlideShow(new ReadContentInputStream(af)); pptx = new XMLSlideShow(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.pptxContainer.init.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.pptxContainer.init.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
List<XSLFPictureData> listOfAllPictures = null; List<XSLFPictureData> listOfAllPictures = null;
try { try {
listOfAllPictures = pptx.getAllPictures(); listOfAllPictures = pptx.getAllPictures();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
// if no images are extracted from the PPT, return null, else initialize // if no images are extracted from the PPT, return null, else initialize
@ -446,9 +446,9 @@ class ImageExtractor {
String fileName = xslsPicture.getFileName(); String fileName = xslsPicture.getFileName();
try { try {
data = xslsPicture.getData(); data = xslsPicture.getData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, fileName).toString(), data);
@ -474,21 +474,21 @@ class ImageExtractor {
Workbook xls; Workbook xls;
try { try {
xls = new HSSFWorkbook(new ReadContentInputStream(af)); xls = new HSSFWorkbook(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, "{0}{1}", new Object[]{NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.xlsContainer.init.err", af.getName()), af.getName()}); //NON-NLS logger.log(Level.WARNING, String.format("%s%s", NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.xlsContainer.init.err", af.getName()), af.getName()), ex); //NON-NLS
return null; return null;
} }
List<? extends org.apache.poi.ss.usermodel.PictureData> listOfAllPictures = null; List<? extends org.apache.poi.ss.usermodel.PictureData> listOfAllPictures = null;
try { try {
listOfAllPictures = xls.getAllPictures(); listOfAllPictures = xls.getAllPictures();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
// if no images are extracted from the PPT, return null, else initialize // if no images are extracted from the PPT, return null, else initialize
// the output folder for image extraction. // the output folder for image extraction.
String outputFolderPath; String outputFolderPath;
@ -509,9 +509,9 @@ class ImageExtractor {
String imageName = UNKNOWN_NAME_PREFIX + i + "." + pictureData.suggestFileExtension(); //NON-NLS String imageName = UNKNOWN_NAME_PREFIX + i + "." + pictureData.suggestFileExtension(); //NON-NLS
try { try {
data = pictureData.getData(); data = pictureData.getData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data);
@ -535,21 +535,21 @@ class ImageExtractor {
Workbook xlsx; Workbook xlsx;
try { try {
xlsx = new XSSFWorkbook(new ReadContentInputStream(af)); xlsx = new XSSFWorkbook(new ReadContentInputStream(af));
} catch (Throwable ignore) { } catch (Throwable ex) {
// instantiating POI containers throw RuntimeExceptions // instantiating POI containers throw RuntimeExceptions
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.xlsxContainer.init.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.xlsxContainer.init.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
List<? extends org.apache.poi.ss.usermodel.PictureData> listOfAllPictures = null; List<? extends org.apache.poi.ss.usermodel.PictureData> listOfAllPictures = null;
try { try {
listOfAllPictures = xlsx.getAllPictures(); listOfAllPictures = xlsx.getAllPictures();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
// if no images are extracted from the PPT, return null, else initialize // if no images are extracted from the PPT, return null, else initialize
// the output folder for image extraction. // the output folder for image extraction.
String outputFolderPath; String outputFolderPath;
@ -570,9 +570,9 @@ class ImageExtractor {
String imageName = UNKNOWN_NAME_PREFIX + i + "." + pictureData.suggestFileExtension(); String imageName = UNKNOWN_NAME_PREFIX + i + "." + pictureData.suggestFileExtension();
try { try {
data = pictureData.getData(); data = pictureData.getData();
} catch (Exception ignore) { } catch (Exception ex) {
// log internal Java and Apache errors as WARNING // log internal Java and Apache errors as WARNING
logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName())); //NON-NLS logger.log(Level.WARNING, NbBundle.getMessage(this.getClass(), "EmbeddedFileExtractorIngestModule.ImageExtractor.processing.err", af.getName()), ex); //NON-NLS
return null; return null;
} }
writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data); writeExtractedImage(Paths.get(outputFolderPath, imageName).toString(), data);