timeline: extracting hard coded strings

This commit is contained in:
Nick Davis 2016-02-04 20:30:29 -05:00
parent f70f840f0e
commit e67d6db9fd
4 changed files with 10 additions and 11 deletions

View File

@ -10,7 +10,7 @@
<fx:root alignment="TOP_RIGHT" maxHeight="-Infinity" maxWidth="-Infinity" type="StackPane" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1"> <fx:root alignment="TOP_RIGHT" maxHeight="-Infinity" maxWidth="-Infinity" type="StackPane" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1">
<children> <children>
<TitledPane collapsible="false" contentDisplay="RIGHT" text="No Visible Events"> <TitledPane fx:id="titledPane" collapsible="false" contentDisplay="RIGHT" text="No Visible Events">
<content> <content>
<VBox alignment="CENTER_LEFT" spacing="5.0"> <VBox alignment="CENTER_LEFT" spacing="5.0">
<children> <children>

View File

@ -34,13 +34,7 @@ import javafx.beans.value.ObservableValue;
import javafx.event.ActionEvent; import javafx.event.ActionEvent;
import javafx.fxml.FXML; import javafx.fxml.FXML;
import javafx.geometry.Insets; import javafx.geometry.Insets;
import javafx.scene.control.Button; import javafx.scene.control.*;
import javafx.scene.control.Label;
import javafx.scene.control.MenuButton;
import javafx.scene.control.Toggle;
import javafx.scene.control.ToggleButton;
import javafx.scene.control.ToolBar;
import javafx.scene.control.Tooltip;
import javafx.scene.effect.Lighting; import javafx.scene.effect.Lighting;
import javafx.scene.image.Image; import javafx.scene.image.Image;
import javafx.scene.image.ImageView; import javafx.scene.image.ImageView;
@ -537,8 +531,11 @@ final public class VisualizationPanel extends BorderPane {
} }
} }
@NbBundle.Messages("NoEventsDialog.titledPane.text=No Visible Events")
private class NoEventsDialog extends StackPane { private class NoEventsDialog extends StackPane {
@FXML
private TitledPane titledPane;
@FXML @FXML
private Button backButton; private Button backButton;
@FXML @FXML
@ -563,6 +560,7 @@ final public class VisualizationPanel extends BorderPane {
assert dismissButton != null : "fx:id=\"dismissButton\" was not injected: check your FXML file 'NoEventsDialog.fxml'."; // NON-NLS assert dismissButton != null : "fx:id=\"dismissButton\" was not injected: check your FXML file 'NoEventsDialog.fxml'."; // NON-NLS
assert zoomButton != null : "fx:id=\"zoomButton\" was not injected: check your FXML file 'NoEventsDialog.fxml'."; // NON-NLS assert zoomButton != null : "fx:id=\"zoomButton\" was not injected: check your FXML file 'NoEventsDialog.fxml'."; // NON-NLS
titledPane.setText(Bundle.NoEventsDialog_titledPane_text());
noEventsDialogLabel.setText(NbBundle.getMessage(NoEventsDialog.class, "VisualizationPanel.noEventsDialogLabel.text")); // NON-NLS noEventsDialogLabel.setText(NbBundle.getMessage(NoEventsDialog.class, "VisualizationPanel.noEventsDialogLabel.text")); // NON-NLS
dismissButton.setOnAction(actionEvent -> closeCallback.run()); dismissButton.setOnAction(actionEvent -> closeCallback.run());

View File

@ -39,7 +39,7 @@
<TreeTableView fx:constant="CONSTRAINED_RESIZE_POLICY" /> <TreeTableView fx:constant="CONSTRAINED_RESIZE_POLICY" />
</columnResizePolicy> </columnResizePolicy>
</TreeTableView> </TreeTableView>
<TitledPane fx:id="hiddenDescriptionsPane" collapsible="false" disable="true" expanded="false" minHeight="25.0" text="Hidden Descriptions"> <TitledPane fx:id="hiddenDescriptionsPane" collapsible="false" disable="true" expanded="false" minHeight="25.0">
<content> <content>
<ListView fx:id="hiddenDescriptionsListView" /> <ListView fx:id="hiddenDescriptionsListView" />
</content> </content>

View File

@ -102,13 +102,14 @@ final public class FilterSetPanel extends BorderPane {
"Timeline.ui.filtering.menuItem.others=others", "Timeline.ui.filtering.menuItem.others=others",
"Timeline.ui.filtering.menuItem.select=select", "Timeline.ui.filtering.menuItem.select=select",
"FilterSetPanel.hiddenDescriptionsListView.unhideAndRm=Unhide and remove from list", "FilterSetPanel.hiddenDescriptionsListView.unhideAndRm=Unhide and remove from list",
"FilterSetPanel.hiddenDescriptionsListView.remove=Remove from list"}) "FilterSetPanel.hiddenDescriptionsListView.remove=Remove from list",
"FilsetSetPanel.hiddenDescriptionsPane.displayName=Hidden Descriptions"})
void initialize() { void initialize() {
assert applyButton != null : "fx:id=\"applyButton\" was not injected: check your FXML file 'FilterSetPanel.fxml'."; // NON-NLS assert applyButton != null : "fx:id=\"applyButton\" was not injected: check your FXML file 'FilterSetPanel.fxml'."; // NON-NLS
ActionUtils.configureButton(new ApplyFiltersAction(), applyButton); ActionUtils.configureButton(new ApplyFiltersAction(), applyButton);
defaultButton.setText(Bundle.FilterSetPanel_defaultButton_text()); defaultButton.setText(Bundle.FilterSetPanel_defaultButton_text());
hiddenDescriptionsPane.setText(Bundle.FilsetSetPanel_hiddenDescriptionsPane_displayName());
//remove column headers via css. //remove column headers via css.
filterTreeTable.getStylesheets().addAll(FilterSetPanel.class.getResource("FilterTable.css").toExternalForm()); // NON-NLS filterTreeTable.getStylesheets().addAll(FilterSetPanel.class.getResource("FilterTable.css").toExternalForm()); // NON-NLS