Remove duplicated code in ExecUtil

This commit is contained in:
Richard Cordovano 2019-10-02 17:28:51 -04:00
parent cb6846b7f2
commit e4449eb2cb
2 changed files with 7 additions and 5 deletions

View File

@ -37,8 +37,8 @@ import org.sleuthkit.autopsy.core.UserPreferences;
public final class ExecUtil {
private static final Logger logger = Logger.getLogger(ExecUtil.class.getName());
private static final long DEFAULT_TIMEOUT = 5;
private static final TimeUnit DEFAULT_TIMEOUT_UNITS = TimeUnit.SECONDS;
private static final long DEFAULT_CHECK_INTERVAL = 5;
private static final TimeUnit DEFAULT_CHECK_INTERVAL_UNITS = TimeUnit.SECONDS;
/**
* The execute() methods do a wait() with a timeout on the executing process
@ -153,7 +153,7 @@ public final class ExecUtil {
* @throws IOException If an I/O error occurs.
*/
public static int execute(ProcessBuilder processBuilder, ProcessTerminator terminator) throws SecurityException, IOException {
return ExecUtil.execute(processBuilder, ExecUtil.DEFAULT_TIMEOUT, ExecUtil.DEFAULT_TIMEOUT_UNITS, terminator);
return ExecUtil.execute(processBuilder, ExecUtil.DEFAULT_CHECK_INTERVAL, ExecUtil.DEFAULT_CHECK_INTERVAL_UNITS, terminator);
}
/**

View File

@ -83,7 +83,9 @@ public class PlasoIngestModule implements DataSourceIngestModule {
private static final String PSORT_EXECUTABLE = "psort.exe";//NON-NLS
private static final String COOKIE = "cookie";//NON-NLS
private static final int LOG2TIMELINE_WORKERS = 2;
private static final long TERMINATION_CHECK_INTERVAL = 5;
private static final TimeUnit TERMINATION_CHECK_INTERVAL_UNITS = TimeUnit.SECONDS;
private File log2TimeLineExecutable;
private File psortExecutable;
@ -164,7 +166,7 @@ public class PlasoIngestModule implements DataSourceIngestModule {
try (BufferedReader log2TimeLineOutpout = new BufferedReader(new InputStreamReader(log2TimeLineProcess.getInputStream()))) {
L2TStatusProcessor statusReader = new L2TStatusProcessor(log2TimeLineOutpout, statusHelper, moduleOutputPath);
new Thread(statusReader, "log2timeline status reader").start(); //NON-NLS
ExecUtil.waitForTermination(LOG2TIMELINE_EXECUTABLE, log2TimeLineProcess, 5, TimeUnit.SECONDS, new DataSourceIngestModuleProcessTerminator(context));
ExecUtil.waitForTermination(LOG2TIMELINE_EXECUTABLE, log2TimeLineProcess, TERMINATION_CHECK_INTERVAL, TERMINATION_CHECK_INTERVAL_UNITS, new DataSourceIngestModuleProcessTerminator(context));
statusReader.cancel();
}