From 806b4a91b01cf14aee1d7ed0874ca49cb3c10302 Mon Sep 17 00:00:00 2001 From: momo Date: Wed, 28 Oct 2015 10:21:31 -0400 Subject: [PATCH 1/5] allow offset with footer --- .../autopsy/modules/filetypeid/FileType.java | 62 ++----------------- .../FileTypeIdGlobalSettingsPanel.java | 19 +++--- .../autopsy/modules/filetypeid/FileTypes.xsd | 8 +-- 3 files changed, 17 insertions(+), 72 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java index cc12a95b5a..132f5b3317 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java @@ -191,49 +191,6 @@ class FileType { this.offset = offset; this.type = Type.RAW; } - - /** - * Creates a file signature consisting of a sequence of bytes at a - * specific offset within a file with default offset. - * - * @param signatureBytes The signature bytes. - * @param isFooter Whether this is a footer or not - * @param type The type of data in the byte array. Impacts - * how it is displayed to the user in the UI. - */ - Signature(final byte[] signatureBytes, boolean isFooter, Type type) { - this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); - this.offset = isFooter ? -1 : 0; - this.type = type; - } - - /** - * Creates a file signature consisting of an ASCII string at a - * specific offset within a file with default offset. - * - * @param signatureString The ASCII string - * @param isFooter Whether this is a footer or not - */ - Signature(String signatureString, boolean isFooter) { - this.signatureBytes = signatureString.getBytes(StandardCharsets.US_ASCII); - this.offset = isFooter ? -1 : 0; - this.type = Type.ASCII; - } - - /** - * Creates a file signature consisting of a sequence of bytes at a - * specific offset within a file with default offset. If bytes - * correspond to an ASCII string, use one of the other constructors - * so that the string is displayed to the user instead of the raw bytes. - * - * @param signatureBytes The signature bytes. - * @param isFooter Whether this is a footer or not - */ - Signature(final byte[] signatureBytes, boolean isFooter) { - this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); - this.offset = isFooter ? -1 : 0; - this.type = Type.RAW; - } /** * Gets the byte sequence of the signature. @@ -270,15 +227,16 @@ class FileType { * * @return True or false. */ - boolean containedIn(final AbstractFile file) { - if(offset == -1) - return containedAsFooter(file); - if (file.getSize() < (offset + signatureBytes.length)) { + boolean containedIn(final AbstractFile file) { + long actualOffset = offset; + if(offset < 0) + actualOffset = file.getSize() - signatureBytes.length + offset+1; + if (file.getSize() < (actualOffset + signatureBytes.length)) { return false; /// too small, can't contain this signature } try { byte[] buffer = new byte[signatureBytes.length]; - int bytesRead = file.read(buffer, offset, signatureBytes.length); + int bytesRead = file.read(buffer, actualOffset, signatureBytes.length); return ((bytesRead == signatureBytes.length) && (Arrays.equals(buffer, signatureBytes))); } catch (TskCoreException ex) { /** @@ -291,14 +249,6 @@ class FileType { } } - private boolean containedAsFooter(final AbstractFile file) { - if(file.getSize() < signatureBytes.length) - return false; - long newOffset = file.getSize() - signatureBytes.length; - Signature newSignature = new Signature(signatureBytes, newOffset); - return newSignature.containedIn(file); - } - @Override public boolean equals(Object other) { if (other != null && other instanceof Signature) { diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java index f45be34df6..712c82823c 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java @@ -203,7 +203,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane boolean requiredFieldsPopulated = !mimeTypeTextField.getText().isEmpty() - && (isFooterCheckBox.isSelected() ? true : !offsetTextField.getText().isEmpty()) + && !offsetTextField.getText().isEmpty() && !signatureTextField.getText().isEmpty() && (postHitCheckBox.isSelected() ? !filesSetNameTextField.getText().isEmpty() : true); saveTypeButton.setEnabled(!ingestIsRunning && requiredFieldsPopulated); @@ -270,14 +270,12 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane } } signatureTextField.setText(signatureBytes); - if(signature.getOffset() == -1) { + if(signature.getOffset() < 0) { isFooterCheckBox.setSelected(true); - offsetTextField.setEnabled(false); - offsetTextField.setText(""); + offsetTextField.setText(Long.toString(signature.getOffset()*-1 -1)); } else { isFooterCheckBox.setSelected(false); - offsetTextField.setEnabled(true); offsetTextField.setText(Long.toString(signature.getOffset())); } postHitCheckBox.setSelected(fileType.alertOnMatch()); @@ -299,7 +297,6 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane hexPrefixLabel.setVisible(true); signatureTextField.setText("0000"); //NON-NLS isFooterCheckBox.setSelected(false); - offsetTextField.setEnabled(true); offsetTextField.setText(""); //NON-NLS postHitCheckBox.setSelected(false); filesSetNameTextField.setText(""); //NON-NLS @@ -635,7 +632,12 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane */ long offset; try { - offset = isFooterCheckBox.isSelected() ? -1 : Long.parseUnsignedLong(offsetTextField.getText()); + if(isFooterCheckBox.isSelected()) { + offset = Long.parseUnsignedLong(offsetTextField.getText())*-1 -1; + } + else { + offset = Long.parseUnsignedLong(offsetTextField.getText()); + } } catch (NumberFormatException ex) { JOptionPane.showMessageDialog(null, NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.JOptionPane.invalidOffset.message"), @@ -693,8 +695,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane }//GEN-LAST:event_signatureTextFieldActionPerformed private void isFooterCheckBoxActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_isFooterCheckBoxActionPerformed - offsetTextField.setEnabled(!isFooterCheckBox.isSelected()); - enableButtons(); + }//GEN-LAST:event_isFooterCheckBoxActionPerformed // Variables declaration - do not modify//GEN-BEGIN:variables diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd index 6ae9505c76..c923441e3d 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd @@ -21,17 +21,11 @@ - - - - - - - + From 39bf598ca92aa9325bd8036343956218135e4043 Mon Sep 17 00:00:00 2001 From: momo Date: Wed, 28 Oct 2015 15:09:44 -0400 Subject: [PATCH 2/5] change implementation to use a boolean variable --- .../autopsy/modules/filetypeid/FileType.java | 62 +++++++++++++++++-- .../FileTypeIdGlobalSettingsPanel.java | 18 ++---- .../autopsy/modules/filetypeid/FileTypes.xsd | 3 +- .../UserDefinedFileTypesManager.java | 19 +++++- 4 files changed, 81 insertions(+), 21 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java index 132f5b3317..451c1d773c 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java @@ -51,7 +51,7 @@ class FileType { */ FileType(String mimeType, final Signature signature, String filesSetName, boolean alert) { this.mimeType = mimeType; - this.signature = new Signature(signature.getSignatureBytes(), signature.getOffset(), signature.getType()); + this.signature = new Signature(signature.getSignatureBytes(), signature.getOffset(), signature.getType(), signature.isTrailing()); this.interestingFilesSetName = filesSetName; this.alert = alert; } @@ -71,7 +71,7 @@ class FileType { * @return The signature. */ Signature getSignature() { - return new Signature(signature.getSignatureBytes(), signature.getOffset(), signature.getType()); + return new Signature(signature.getSignatureBytes(), signature.getOffset(), signature.getType(), signature.isTrailing()); } /** @@ -148,6 +148,7 @@ class FileType { private final byte[] signatureBytes; private final long offset; private final Type type; + private final boolean trailing; /** * Creates a file signature consisting of a sequence of bytes at a @@ -162,6 +163,7 @@ class FileType { this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); this.offset = offset; this.type = type; + this.trailing = false; } /** @@ -175,6 +177,7 @@ class FileType { this.signatureBytes = signatureString.getBytes(StandardCharsets.US_ASCII); this.offset = offset; this.type = Type.ASCII; + this.trailing = false; } /** @@ -190,6 +193,53 @@ class FileType { this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); this.offset = offset; this.type = Type.RAW; + this.trailing = false; + } + + /** + * Creates a file signature consisting of a sequence of bytes at a + * specific offset within a file. + * + * @param signatureBytes The signature bytes. + * @param offset The offset of the signature bytes. + * @param type The type of data in the byte array. Impacts + * how it is displayed to the user in the UI. + */ + Signature(final byte[] signatureBytes, long offset, Type type, boolean isFooter) { + this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); + this.offset = offset; + this.type = type; + this.trailing = isFooter; + } + + /** + * Creates a file signature consisting of an ASCII string at a + * specific offset within a file. + * + * @param signatureString The ASCII string + * @param offset The offset of the signature bytes. + */ + Signature(String signatureString, long offset, boolean isFooter) { + this.signatureBytes = signatureString.getBytes(StandardCharsets.US_ASCII); + this.offset = offset; + this.type = Type.ASCII; + this.trailing = isFooter; + } + + /** + * Creates a file signature consisting of a sequence of bytes at a + * specific offset within a file. If bytes correspond to an ASCII + * string, use one of the other constructors so that the string is + * displayed to the user instead of the raw bytes. + * + * @param signatureBytes The signature bytes. + * @param offset The offset of the signature bytes. + */ + Signature(final byte[] signatureBytes, long offset, boolean isFooter) { + this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); + this.offset = offset; + this.type = Type.RAW; + this.trailing = isFooter; } /** @@ -218,6 +268,10 @@ class FileType { Type getType() { return type; } + + boolean isTrailing() { + return trailing; + } /** * Determines whether or not the signature is contained within a given @@ -229,8 +283,8 @@ class FileType { */ boolean containedIn(final AbstractFile file) { long actualOffset = offset; - if(offset < 0) - actualOffset = file.getSize() - signatureBytes.length + offset+1; + if(trailing) + actualOffset = file.getSize() - signatureBytes.length - offset; if (file.getSize() < (actualOffset + signatureBytes.length)) { return false; /// too small, can't contain this signature } diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java index 712c82823c..b721936057 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java @@ -270,14 +270,8 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane } } signatureTextField.setText(signatureBytes); - if(signature.getOffset() < 0) { - isFooterCheckBox.setSelected(true); - offsetTextField.setText(Long.toString(signature.getOffset()*-1 -1)); - } - else { - isFooterCheckBox.setSelected(false); - offsetTextField.setText(Long.toString(signature.getOffset())); - } + isFooterCheckBox.setSelected(signature.isTrailing()); + offsetTextField.setText(Long.toString(signature.getOffset())); postHitCheckBox.setSelected(fileType.alertOnMatch()); filesSetNameTextField.setEnabled(postHitCheckBox.isSelected()); filesSetNameTextField.setText(fileType.getFilesSetName()); @@ -632,12 +626,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane */ long offset; try { - if(isFooterCheckBox.isSelected()) { - offset = Long.parseUnsignedLong(offsetTextField.getText())*-1 -1; - } - else { offset = Long.parseUnsignedLong(offsetTextField.getText()); - } } catch (NumberFormatException ex) { JOptionPane.showMessageDialog(null, NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.JOptionPane.invalidOffset.message"), @@ -664,7 +653,8 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane /** * Put it all together and reset the file types list component. */ - FileType.Signature signature = new FileType.Signature(signatureBytes, offset, sigType); + boolean isTrailing = isFooterCheckBox.isSelected(); + FileType.Signature signature = new FileType.Signature(signatureBytes, offset, sigType, isFooterCheckBox.isSelected()); FileType fileType = new FileType(typeName, signature, filesSetName, postHitCheckBox.isSelected()); FileType selected = typesList.getSelectedValue(); if (selected != null) { diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd index c923441e3d..63dab70d24 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypes.xsd @@ -25,7 +25,8 @@ - + + diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/UserDefinedFileTypesManager.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/UserDefinedFileTypesManager.java index 47a3a0f97b..4d801c79be 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/UserDefinedFileTypesManager.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/UserDefinedFileTypesManager.java @@ -38,6 +38,7 @@ import org.sleuthkit.autopsy.coreutils.Logger; import org.sleuthkit.autopsy.coreutils.PlatformUtil; import org.sleuthkit.autopsy.coreutils.XMLUtil; import org.sleuthkit.autopsy.modules.filetypeid.FileType.Signature; +import org.w3c.dom.Node; import org.xml.sax.SAXException; /** @@ -67,6 +68,7 @@ final class UserDefinedFileTypesManager { private static final String SIGNATURE_TYPE_ATTRIBUTE = "type"; //NON-NLS private static final String BYTES_TAG_NAME = "Bytes"; //NON-NLS private static final String OFFSET_TAG_NAME = "Offset"; //NON-NLS + private static final String TRAILING_TAG_NAME = "Trailing"; private static final String INTERESTING_FILES_SET_TAG_NAME = "InterestingFileSset"; //NON-NLS private static final String ALERT_ATTRIBUTE = "alert"; //NON-NLS private static final String ENCODING_FOR_XML_FILE = "UTF-8"; //NON-NLS @@ -372,6 +374,10 @@ final class UserDefinedFileTypesManager { Element offsetElem = doc.createElement(OFFSET_TAG_NAME); offsetElem.setTextContent(DatatypeConverter.printLong(signature.getOffset())); signatureElem.appendChild(offsetElem); + + Element trailingElem = doc.createElement(TRAILING_TAG_NAME); + trailingElem.setTextContent(DatatypeConverter.printBoolean(signature.isTrailing())); + signatureElem.appendChild(trailingElem); signatureElem.setAttribute(SIGNATURE_TYPE_ATTRIBUTE, signature.getType().toString()); fileTypeElem.appendChild(signatureElem); @@ -482,8 +488,14 @@ final class UserDefinedFileTypesManager { String offsetString = getChildElementTextContent(signatureElem, OFFSET_TAG_NAME); long offset = DatatypeConverter.parseLong(offsetString); + + String trailingString = getChildElementTextContent(signatureElem, TRAILING_TAG_NAME); + if(trailingString == null) + return new Signature(signatureBytes, offset, signatureType); + + boolean trailing = DatatypeConverter.parseBoolean(trailingString); - return new Signature(signatureBytes, offset, signatureType); + return new Signature(signatureBytes, offset, signatureType, trailing); } /** @@ -525,7 +537,10 @@ final class UserDefinedFileTypesManager { */ private static String getChildElementTextContent(Element elem, String tagName) { NodeList childElems = elem.getElementsByTagName(tagName); - Element childElem = (Element) childElems.item(0); + Node childNode = childElems.item(0); + if(childNode == null) + return null; + Element childElem = (Element) childNode; return childElem.getTextContent(); } From 796e4417654e87458fa0f685da2bf4b66edf813c Mon Sep 17 00:00:00 2001 From: momo Date: Wed, 28 Oct 2015 15:11:46 -0400 Subject: [PATCH 3/5] change variable names --- .../modules/filetypeid/Bundle.properties | 2 +- .../autopsy/modules/filetypeid/FileType.java | 17 +++++++----- .../FileTypeIdGlobalSettingsPanel.form | 10 +++---- .../FileTypeIdGlobalSettingsPanel.java | 26 +++++++++---------- 4 files changed, 29 insertions(+), 26 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/Bundle.properties b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/Bundle.properties index 7ac6b9fc2c..bc99ea014f 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/Bundle.properties +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/Bundle.properties @@ -46,4 +46,4 @@ FileTypeIdGlobalSettingsPanel.jLabel2.text=MIME Types: FileTypeIdGlobalSettingsPanel.jLabel3.text=Autopsy can automatically detect many file types. Add your custom file types here. FileTypeIdGlobalSettingsPanel.startUp.fileTypeDetectorInitializationException.msg=Error initializing the file type detector. FileTypeIdIngestModule.startUp.fileTypeDetectorInitializationException.msg=Error initializing the file type detector. -FileTypeIdGlobalSettingsPanel.isFooterCheckBox.text=This signature is a footer +FileTypeIdGlobalSettingsPanel.isTrailingCheckBox.text=This signature is a trailing diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java index 451c1d773c..133c1c6f84 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileType.java @@ -203,13 +203,14 @@ class FileType { * @param signatureBytes The signature bytes. * @param offset The offset of the signature bytes. * @param type The type of data in the byte array. Impacts - * how it is displayed to the user in the UI. + * how it is displayed to the user in the UI. + * @param trailing Determines whether this signature is trailing. */ - Signature(final byte[] signatureBytes, long offset, Type type, boolean isFooter) { + Signature(final byte[] signatureBytes, long offset, Type type, boolean trailing) { this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); this.offset = offset; this.type = type; - this.trailing = isFooter; + this.trailing = trailing; } /** @@ -218,12 +219,13 @@ class FileType { * * @param signatureString The ASCII string * @param offset The offset of the signature bytes. + * @param trailing Determines whether this signature is trailing. */ - Signature(String signatureString, long offset, boolean isFooter) { + Signature(String signatureString, long offset, boolean trailing) { this.signatureBytes = signatureString.getBytes(StandardCharsets.US_ASCII); this.offset = offset; this.type = Type.ASCII; - this.trailing = isFooter; + this.trailing = trailing; } /** @@ -234,12 +236,13 @@ class FileType { * * @param signatureBytes The signature bytes. * @param offset The offset of the signature bytes. + * @param trailing Determines whether this signature is trailing. */ - Signature(final byte[] signatureBytes, long offset, boolean isFooter) { + Signature(final byte[] signatureBytes, long offset, boolean trailing) { this.signatureBytes = Arrays.copyOf(signatureBytes, signatureBytes.length); this.offset = offset; this.type = Type.RAW; - this.trailing = isFooter; + this.trailing = trailing; } /** diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.form b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.form index 030695446f..0e51a3c6bc 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.form +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.form @@ -83,7 +83,7 @@ - + @@ -140,7 +140,7 @@ - + @@ -353,14 +353,14 @@ - + - + - + diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java index b721936057..690cef660a 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java @@ -270,7 +270,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane } } signatureTextField.setText(signatureBytes); - isFooterCheckBox.setSelected(signature.isTrailing()); + isTrailingCheckBox.setSelected(signature.isTrailing()); offsetTextField.setText(Long.toString(signature.getOffset())); postHitCheckBox.setSelected(fileType.alertOnMatch()); filesSetNameTextField.setEnabled(postHitCheckBox.isSelected()); @@ -290,7 +290,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane signatureTypeComboBox.setSelectedItem(FileTypeIdGlobalSettingsPanel.RAW_SIGNATURE_TYPE_COMBO_BOX_ITEM); hexPrefixLabel.setVisible(true); signatureTextField.setText("0000"); //NON-NLS - isFooterCheckBox.setSelected(false); + isTrailingCheckBox.setSelected(false); offsetTextField.setText(""); //NON-NLS postHitCheckBox.setSelected(false); filesSetNameTextField.setText(""); //NON-NLS @@ -362,7 +362,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane jLabel1 = new javax.swing.JLabel(); jLabel2 = new javax.swing.JLabel(); jLabel3 = new javax.swing.JLabel(); - isFooterCheckBox = new javax.swing.JCheckBox(); + isTrailingCheckBox = new javax.swing.JCheckBox(); setMaximumSize(new java.awt.Dimension(500, 300)); setPreferredSize(new java.awt.Dimension(500, 300)); @@ -442,10 +442,10 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane org.openide.awt.Mnemonics.setLocalizedText(jLabel3, org.openide.util.NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.jLabel3.text")); // NOI18N - org.openide.awt.Mnemonics.setLocalizedText(isFooterCheckBox, org.openide.util.NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.isFooterCheckBox.text")); // NOI18N - isFooterCheckBox.addActionListener(new java.awt.event.ActionListener() { + org.openide.awt.Mnemonics.setLocalizedText(isTrailingCheckBox, org.openide.util.NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.isTrailingCheckBox.text")); // NOI18N + isTrailingCheckBox.addActionListener(new java.awt.event.ActionListener() { public void actionPerformed(java.awt.event.ActionEvent evt) { - isFooterCheckBoxActionPerformed(evt); + isTrailingCheckBoxActionPerformed(evt); } }); @@ -502,7 +502,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane .addGroup(javax.swing.GroupLayout.Alignment.TRAILING, layout.createSequentialGroup() .addComponent(saveTypeButton) .addGap(8, 8, 8)) - .addComponent(isFooterCheckBox))) + .addComponent(isTrailingCheckBox))) .addComponent(jLabel1) .addComponent(jLabel3)) .addContainerGap(50, Short.MAX_VALUE)))) @@ -544,7 +544,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane .addComponent(signatureTextField, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)) .addComponent(signatureLabel)) .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) - .addComponent(isFooterCheckBox) + .addComponent(isTrailingCheckBox) .addPreferredGap(javax.swing.LayoutStyle.ComponentPlacement.RELATED) .addGroup(layout.createParallelGroup(javax.swing.GroupLayout.Alignment.BASELINE) .addComponent(offsetTextField, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE) @@ -653,8 +653,8 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane /** * Put it all together and reset the file types list component. */ - boolean isTrailing = isFooterCheckBox.isSelected(); - FileType.Signature signature = new FileType.Signature(signatureBytes, offset, sigType, isFooterCheckBox.isSelected()); + boolean isTrailing = isTrailingCheckBox.isSelected(); + FileType.Signature signature = new FileType.Signature(signatureBytes, offset, sigType, isTrailingCheckBox.isSelected()); FileType fileType = new FileType(typeName, signature, filesSetName, postHitCheckBox.isSelected()); FileType selected = typesList.getSelectedValue(); if (selected != null) { @@ -684,9 +684,9 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane // TODO add your handling code here: }//GEN-LAST:event_signatureTextFieldActionPerformed - private void isFooterCheckBoxActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_isFooterCheckBoxActionPerformed + private void isTrailingCheckBoxActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_isTrailingCheckBoxActionPerformed - }//GEN-LAST:event_isFooterCheckBoxActionPerformed + }//GEN-LAST:event_isTrailingCheckBoxActionPerformed // Variables declaration - do not modify//GEN-BEGIN:variables private javax.swing.JButton deleteTypeButton; @@ -694,7 +694,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane private javax.swing.JTextField filesSetNameTextField; private javax.swing.JLabel hexPrefixLabel; private javax.swing.JLabel ingestRunningWarningLabel; - private javax.swing.JCheckBox isFooterCheckBox; + private javax.swing.JCheckBox isTrailingCheckBox; private javax.swing.JLabel jLabel1; private javax.swing.JLabel jLabel2; private javax.swing.JLabel jLabel3; From a09548f79a1ef4427bfd4cdf5652db6b763f6f6f Mon Sep 17 00:00:00 2001 From: Mohammad Yahya Date: Wed, 28 Oct 2015 15:26:51 -0400 Subject: [PATCH 4/5] remove extra indentation --- .../modules/filetypeid/FileTypeIdGlobalSettingsPanel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java index 690cef660a..b74b7e67cc 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java @@ -626,7 +626,7 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane */ long offset; try { - offset = Long.parseUnsignedLong(offsetTextField.getText()); + offset = Long.parseUnsignedLong(offsetTextField.getText()); } catch (NumberFormatException ex) { JOptionPane.showMessageDialog(null, NbBundle.getMessage(FileTypeIdGlobalSettingsPanel.class, "FileTypeIdGlobalSettingsPanel.JOptionPane.invalidOffset.message"), From b02c78bea76d392e7fb43c342a1cf579ac6d5d92 Mon Sep 17 00:00:00 2001 From: Mohammad Yahya Date: Wed, 28 Oct 2015 15:28:51 -0400 Subject: [PATCH 5/5] Delete debug line --- .../modules/filetypeid/FileTypeIdGlobalSettingsPanel.java | 1 - 1 file changed, 1 deletion(-) diff --git a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java index b74b7e67cc..58afdd266a 100644 --- a/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java +++ b/Core/src/org/sleuthkit/autopsy/modules/filetypeid/FileTypeIdGlobalSettingsPanel.java @@ -653,7 +653,6 @@ final class FileTypeIdGlobalSettingsPanel extends IngestModuleGlobalSettingsPane /** * Put it all together and reset the file types list component. */ - boolean isTrailing = isTrailingCheckBox.isSelected(); FileType.Signature signature = new FileType.Signature(signatureBytes, offset, sigType, isTrailingCheckBox.isSelected()); FileType fileType = new FileType(typeName, signature, filesSetName, postHitCheckBox.isSelected()); FileType selected = typesList.getSelectedValue();