mstoeck3/autopsy-flatpak
1
0
Fork 0
mirror of https://github.com/overcuriousity/autopsy-flatpak.git synced 2025-07-14 17:06:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't call getNewValue and getOldValue unless they are needed

Browse Source 
they might invoke expensive db operations to load transient members and should be avoided unless those values are needed
This commit is contained in:
jmillman 2015-07-01 13:06:54 -04:00
parent fc3accc733
commit bb7ab1eab3
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
KeywordSearch/src/org/sleuthkit/autopsy/keywordsearch/KeywordSearch.java
View File

@ -23,15 +23,15 @@ import java.beans.PropertyChangeListener;
import java.beans.PropertyChangeSupport;
import java.io.IOException;
import java.util.logging.FileHandler;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.logging.SimpleFormatter;
import org.openide.util.Exceptions;
import org.openide.util.NbBundle;
import org.sleuthkit.autopsy.casemodule.Case;
import org.sleuthkit.autopsy.coreutils.MessageNotifyUtil;
import org.sleuthkit.autopsy.coreutils.PlatformUtil;
import org.sleuthkit.autopsy.keywordsearch.KeywordSearchResultFactory.BlackboardResultWriter;
import org.sleuthkit.autopsy.coreutils.MessageNotifyUtil;
import java.util.logging.Level;
/**
* Wrapper over KeywordSearch Solr server singleton.
@ -123,11 +123,14 @@ public class KeywordSearch {
@Override
public void propertyChange(PropertyChangeEvent evt) {
String changed = evt.getPropertyName();
Object oldValue = evt.getOldValue();
Object newValue = evt.getNewValue();
final Logger logger = Logger.getLogger(CaseChangeListener.class.getName());
if (changed.equals(Case.Events.CURRENT_CASE.toString())) {
/* don't call getOld/NewValue() unless they are needed, since
* they might do expensive db operations to load transient
* values lost in serialization */
Object oldValue = evt.getOldValue();
Object newValue = evt.getNewValue();
if (newValue != null) {
// new case is open
try {