From b7ef4bec44a19fb3600b8b05e24921ee8cb4e86d Mon Sep 17 00:00:00 2001 From: Kelly Kelly Date: Wed, 23 Oct 2019 15:39:32 -0400 Subject: [PATCH] Fixed codacy issues --- .../autopsy/geolocation/GeolocationTopComponent.java | 7 ------- .../org/sleuthkit/autopsy/geolocation/MapPanel.java | 11 +++++++---- .../sleuthkit/autopsy/geolocation/RefreshPanel.java | 6 ++++-- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/Core/src/org/sleuthkit/autopsy/geolocation/GeolocationTopComponent.java b/Core/src/org/sleuthkit/autopsy/geolocation/GeolocationTopComponent.java index 7e096aa4d7..cf76a66a66 100755 --- a/Core/src/org/sleuthkit/autopsy/geolocation/GeolocationTopComponent.java +++ b/Core/src/org/sleuthkit/autopsy/geolocation/GeolocationTopComponent.java @@ -136,11 +136,6 @@ public final class GeolocationTopComponent extends TopComponent { super.componentOpened(); WindowManager.getDefault().setTopComponentFloating(this, true); } - - @Override - public void open() { - super.open(); - } /** * Set the state of the refresh panel at the top of the mapPanel. @@ -165,8 +160,6 @@ public final class GeolocationTopComponent extends TopComponent { SwingWorker, Waypoint> worker = new SwingWorker, Waypoint>() { @Override protected List doInBackground() throws Exception { - List waypoints = new ArrayList<>(); - Case currentCase = Case.getCurrentCaseThrows(); return MapWaypoint.getWaypoints(currentCase.getSleuthkitCase()); diff --git a/Core/src/org/sleuthkit/autopsy/geolocation/MapPanel.java b/Core/src/org/sleuthkit/autopsy/geolocation/MapPanel.java index 7abc1ff5be..9aace08818 100755 --- a/Core/src/org/sleuthkit/autopsy/geolocation/MapPanel.java +++ b/Core/src/org/sleuthkit/autopsy/geolocation/MapPanel.java @@ -39,12 +39,12 @@ import org.jxmapviewer.viewer.WaypointPainter; /** * Main panel with the JJXMapViewer object and its basic controls. */ -public class MapPanel extends javax.swing.JPanel { +final class MapPanel extends javax.swing.JPanel { private static final long serialVersionUID = 1L; - private boolean zoomChanging = false; - private boolean sliderReversed = false; + private boolean zoomChanging; + private final boolean sliderReversed; // Using a DefaultListModel to store the way points because we get // a lot of functionality for free, like listeners. @@ -53,8 +53,11 @@ public class MapPanel extends javax.swing.JPanel { /** * Creates new form MapPanel */ - public MapPanel() { + MapPanel() { waypointListModel = new DefaultListModel<>(); + sliderReversed = false; + zoomChanging = false; + initComponents(); initMap(); } diff --git a/Core/src/org/sleuthkit/autopsy/geolocation/RefreshPanel.java b/Core/src/org/sleuthkit/autopsy/geolocation/RefreshPanel.java index d53dd26b70..e7ff40f31c 100755 --- a/Core/src/org/sleuthkit/autopsy/geolocation/RefreshPanel.java +++ b/Core/src/org/sleuthkit/autopsy/geolocation/RefreshPanel.java @@ -26,12 +26,14 @@ import javax.swing.JPanel; * due to new artifacts. * */ -class RefreshPanel extends JPanel { +final class RefreshPanel extends JPanel { + + private static final long serialVersionUID = 1L; /** * Creates new form RefreshPanel */ - public RefreshPanel() { + RefreshPanel() { initComponents(); }