From 909296cc0592a4a4fb02efa493096257a99bdfe4 Mon Sep 17 00:00:00 2001
From: Greg DiCristofaro <gregd@basistech.com>
Date: Tue, 15 Jun 2021 19:42:49 -0400
Subject: [PATCH] weak listeners for hosts and persons

---
 Core/src/org/sleuthkit/autopsy/datamodel/HostNode.java   | 5 +++--
 Core/src/org/sleuthkit/autopsy/datamodel/PersonNode.java | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/Core/src/org/sleuthkit/autopsy/datamodel/HostNode.java b/Core/src/org/sleuthkit/autopsy/datamodel/HostNode.java
index 1f349fdfc4..d736eaa0e9 100644
--- a/Core/src/org/sleuthkit/autopsy/datamodel/HostNode.java
+++ b/Core/src/org/sleuthkit/autopsy/datamodel/HostNode.java
@@ -189,6 +189,8 @@ public class HostNode extends DisplayableItemNode {
             }
         }
     };
+    
+    private final PropertyChangeListener weakPcl = WeakListeners.propertyChange(hostChangePcl, null);
 
     /*
      * Get the host name or 'unknown host' if null.
@@ -247,8 +249,7 @@ public class HostNode extends DisplayableItemNode {
                 host == null ? Lookups.fixed(displayName) : Lookups.fixed(host, displayName));
                 
         hostId = host == null ? null : host.getHostId();
-        Case.addEventTypeSubscriber(EnumSet.of(Case.Events.HOSTS_UPDATED),
-                WeakListeners.propertyChange(hostChangePcl, this));
+        Case.addEventTypeSubscriber(EnumSet.of(Case.Events.HOSTS_UPDATED), weakPcl);
         super.setName(displayName);
         super.setDisplayName(displayName);
         this.setIconBaseWithExtension(ICON_PATH);
diff --git a/Core/src/org/sleuthkit/autopsy/datamodel/PersonNode.java b/Core/src/org/sleuthkit/autopsy/datamodel/PersonNode.java
index 06d52b8662..73db7648dd 100644
--- a/Core/src/org/sleuthkit/autopsy/datamodel/PersonNode.java
+++ b/Core/src/org/sleuthkit/autopsy/datamodel/PersonNode.java
@@ -173,6 +173,8 @@ public class PersonNode extends DisplayableItemNode {
             }
         }
     };
+    
+    private final PropertyChangeListener weakPcl = WeakListeners.propertyChange(personChangePcl, null);
 
     /**
      * Gets the display name for this person or "Unknown Persons".
@@ -210,8 +212,7 @@ public class PersonNode extends DisplayableItemNode {
         this.setIconBaseWithExtension(ICON_PATH);
         this.person = person;
         this.personId = person == null ? null : person.getPersonId();
-        Case.addEventTypeSubscriber(EnumSet.of(Case.Events.PERSONS_UPDATED),
-                WeakListeners.propertyChange(personChangePcl, this));
+        Case.addEventTypeSubscriber(EnumSet.of(Case.Events.PERSONS_UPDATED), weakPcl);
     }
 
     @Override