cleanup, notes, narrower access on a few items

This commit is contained in:
Brian Sweeney 2018-03-15 09:28:26 -06:00
parent 1130004c0c
commit 7d62a9cfca
3 changed files with 6 additions and 7 deletions

View File

@ -28,7 +28,7 @@ import org.sleuthkit.autopsy.datamodel.CommonFileNode;
/** /**
* Makes nodes for common files search results. * Makes nodes for common files search results.
*/ */
final class CommonFilesChildren extends Children.Keys<AbstractFile> { final class CommonFilesChildren extends Children.Keys<AbstractFile> { //TODO extend ChildFactory rather than Children.Keys
private final java.util.Map<String, Integer> instanceCountMap; private final java.util.Map<String, Integer> instanceCountMap;
private final java.util.Map<String, String> dataSourceMap; private final java.util.Map<String, String> dataSourceMap;
@ -50,7 +50,8 @@ final class CommonFilesChildren extends Children.Keys<AbstractFile> {
String dataSources = this.dataSourceMap.get(md5Hash); String dataSources = this.dataSourceMap.get(md5Hash);
Node[] node = new Node[1]; Node[] node = new Node[1];
node[0] = new CommonFileNode(t, instanceCount, dataSources); final CommonFileNode commonFileNode = new CommonFileNode(t, instanceCount, dataSources);
node[0] = commonFileNode;
return node; return node;
} }

View File

@ -18,7 +18,6 @@
*/ */
package org.sleuthkit.autopsy.commonfilesearch; package org.sleuthkit.autopsy.commonfilesearch;
import java.util.ArrayList;
import java.util.List; import java.util.List;
import org.openide.nodes.AbstractNode; import org.openide.nodes.AbstractNode;
import org.openide.util.NbBundle; import org.openide.util.NbBundle;
@ -28,10 +27,9 @@ import org.sleuthkit.datamodel.AbstractFile;
* Encapsulates data used to display common files search results in the top * Encapsulates data used to display common files search results in the top
* right pane. * right pane.
*/ */
//TODO rename to CommonFilesSearchNode
final class CommonFilesSearchNode extends AbstractNode { final class CommonFilesSearchNode extends AbstractNode {
private CommonFilesChildren children; private final CommonFilesChildren children;
CommonFilesSearchNode(List<AbstractFile> keys, java.util.Map<String, Integer> instanceCountMap, java.util.Map<String, String> dataSourceMap) { CommonFilesSearchNode(List<AbstractFile> keys, java.util.Map<String, Integer> instanceCountMap, java.util.Map<String, String> dataSourceMap) {
super(new CommonFilesChildren(true, keys, instanceCountMap, dataSourceMap)); super(new CommonFilesChildren(true, keys, instanceCountMap, dataSourceMap));
@ -39,7 +37,7 @@ final class CommonFilesSearchNode extends AbstractNode {
} }
@NbBundle.Messages({ @NbBundle.Messages({
"CommonFilesNode.getName.text=CommonFiles"}) "CommonFilesNode.getName.text=Common Files"})
@Override @Override
public String getName() { public String getName() {
return Bundle.CommonFilesNode_getName_text(); return Bundle.CommonFilesNode_getName_text();

View File

@ -30,7 +30,7 @@ import org.sleuthkit.datamodel.AbstractFile;
/** /**
* Encapsulates data being pushed to Common Files component in top right pane. * Encapsulates data being pushed to Common Files component in top right pane.
*/ */
public class CommonFileNode extends AbstractNode { public class CommonFileNode extends AbstractNode { //TODO FileNode
private final AbstractFile content; private final AbstractFile content;