addressing codacy remarks

This commit is contained in:
Greg DiCristofaro 2020-09-08 12:10:49 -04:00
parent 66ad332521
commit 2dfa450b5c
4 changed files with 11 additions and 6 deletions

View File

@ -86,7 +86,7 @@ public class SizeRepresentationUtil {
} }
} }
String fullSize = String.valueOf(size) + UNITS.get(0); String fullSize = size + UNITS.get(0);
String closestUnitSize = format.format(approximateSize) + UNITS.get(unitsIndex); String closestUnitSize = format.format(approximateSize) + UNITS.get(unitsIndex);
if (unitsIndex == 0) { if (unitsIndex == 0) {
@ -97,4 +97,7 @@ public class SizeRepresentationUtil {
return closestUnitSize; return closestUnitSize;
} }
} }
private SizeRepresentationUtil() {
}
} }

View File

@ -33,6 +33,8 @@ import org.sleuthkit.autopsy.coreutils.Logger;
"AbstractLoadableComponent_noDataExists_defaultText=No data exists.",}) "AbstractLoadableComponent_noDataExists_defaultText=No data exists.",})
public abstract class AbstractLoadableComponent<T> extends JPanel implements LoadableComponent<T> { public abstract class AbstractLoadableComponent<T> extends JPanel implements LoadableComponent<T> {
private static final long serialVersionUID = 1L;
/** /**
* The default loading message. * The default loading message.
*/ */

View File

@ -49,7 +49,7 @@ public class JTablePanel<T> extends AbstractLoadableComponent<List<T>> {
private static class Overlay extends LayerUI<JComponent> { private static class Overlay extends LayerUI<JComponent> {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private BaseMessageOverlay overlay = new BaseMessageOverlay(); private final BaseMessageOverlay overlayDelegate = new BaseMessageOverlay();
/** /**
* Sets this layer visible when painted. In order to be shown in UI, * Sets this layer visible when painted. In order to be shown in UI,
@ -58,7 +58,7 @@ public class JTablePanel<T> extends AbstractLoadableComponent<List<T>> {
* @param visible Whether or not it is visible. * @param visible Whether or not it is visible.
*/ */
void setVisible(boolean visible) { void setVisible(boolean visible) {
overlay.setVisible(visible); overlayDelegate.setVisible(visible);
} }
/** /**
@ -67,13 +67,13 @@ public class JTablePanel<T> extends AbstractLoadableComponent<List<T>> {
* @param message The message to be displayed. * @param message The message to be displayed.
*/ */
void setMessage(String message) { void setMessage(String message) {
overlay.setMessage(message); overlayDelegate.setMessage(message);
} }
@Override @Override
public void paint(Graphics g, JComponent c) { public void paint(Graphics g, JComponent c) {
super.paint(g, c); super.paint(g, c);
overlay.paintOverlay(g, c.getWidth(), c.getHeight()); overlayDelegate.paintOverlay(g, c.getWidth(), c.getHeight());
} }
} }

View File

@ -80,7 +80,7 @@ public class PieChartPanel extends AbstractLoadableComponent<List<PieChartPanel.
private static class MessageOverlay extends AbstractOverlay implements Overlay { private static class MessageOverlay extends AbstractOverlay implements Overlay {
private static final long serialVersionUID = 1L; private static final long serialVersionUID = 1L;
private BaseMessageOverlay overlay = new BaseMessageOverlay(); private final BaseMessageOverlay overlay = new BaseMessageOverlay();
/** /**
* Sets this layer visible when painted. In order to be shown in UI, * Sets this layer visible when painted. In order to be shown in UI,