better error message

This commit is contained in:
Greg DiCristofaro 2023-08-25 07:56:29 -04:00
parent cfb619aaad
commit 227d32d1c0

View File

@ -158,16 +158,23 @@ class CTCloudHttpClient {
// Parse Response // Parse Response
if (classType != null) { if (classType != null) {
HttpEntity entity = response.getEntity(); HttpEntity entity = response.getEntity();
String entityStr = EntityUtils.toString(entity); if (entity != null) {
O respObj = mapper.readValue(entityStr, classType); String entityStr = EntityUtils.toString(entity);
return respObj; if (StringUtils.isNotBlank(entityStr)) {
} else { O respObj = mapper.readValue(entityStr, classType);
return null; return respObj;
}
}
} }
return null;
} else { } else {
LOGGER.log(Level.WARNING, "Response Received. - Status Error {}", response.getStatusLine()); LOGGER.log(Level.WARNING, "Response Received. - Status Error {}", response.getStatusLine());
handleNonOKResponse(response, ""); handleNonOKResponse(response, "");
} }
// transform all non-CTCloudException's into a CTCloudException
} catch (CTCloudException ex) {
throw ex;
} catch (Exception ex) { } catch (Exception ex) {
LOGGER.log(Level.WARNING, "Error when parsing response from CyberTriage Cloud", ex); LOGGER.log(Level.WARNING, "Error when parsing response from CyberTriage Cloud", ex);
throw new CTCloudException(CTCloudException.parseUnknownException(ex), ex); throw new CTCloudException(CTCloudException.parseUnknownException(ex), ex);