code review comments

This commit is contained in:
Karl Mortensen 2015-05-14 16:50:35 -04:00
parent 94600895d7
commit 13acb13ee9
6 changed files with 14 additions and 14 deletions

View File

@ -75,7 +75,7 @@ public class Case implements SleuthkitCase.ErrorObserver {
private static final String autopsyVer = Version.getVersion(); // current version of autopsy. Change it when the version is changed private static final String autopsyVer = Version.getVersion(); // current version of autopsy. Change it when the version is changed
private static final String EVENT_CHANNEL_NAME = "%s-Case-Events"; private static final String EVENT_CHANNEL_NAME = "%s-Case-Events";
private static String appName = null; private static String appName = null;
/** /**
* Name for the property that determines whether to show the dialog at * Name for the property that determines whether to show the dialog at
* startup * startup
@ -886,11 +886,11 @@ public class Case implements SleuthkitCase.ErrorObserver {
* @return absolute path to the module output dir * @return absolute path to the module output dir
*/ */
public String getModulesOutputDirAbsPath() { public String getModulesOutputDirAbsPath() {
Path thePath = Paths.get(this.getHostDirectory(), MODULE_FOLDER); File modulePath = new File(this.getHostDirectory() + File.separator + MODULE_FOLDER);
if (!thePath.toFile().exists()) { if (!modulePath.exists()) {
thePath.toFile().mkdirs(); modulePath.mkdirs();
} }
return thePath.toString(); return modulePath.toString();
} }
/** /**
@ -900,7 +900,7 @@ public class Case implements SleuthkitCase.ErrorObserver {
* *
* @return relative path to the module output dir * @return relative path to the module output dir
*/ */
public String getModuleOutputDirectoryRelativePath() { public String getModulesOutputDirRelPath() {
Path thePath; Path thePath;
if (getCaseType() == CaseType.MULTI_USER_CASE) { if (getCaseType() == CaseType.MULTI_USER_CASE) {
thePath = Paths.get(HostName, MODULE_FOLDER); thePath = Paths.get(HostName, MODULE_FOLDER);

View File

@ -105,7 +105,7 @@ public final class SevenZipIngestModule implements FileIngestModule {
final Case currentCase = Case.getCurrentCase(); final Case currentCase = Case.getCurrentCase();
moduleDirRelative = currentCase.getModuleOutputDirectoryRelativePath() + File.separator + ArchiveFileExtractorModuleFactory.getModuleName(); moduleDirRelative = currentCase.getModulesOutputDirRelPath() + File.separator + ArchiveFileExtractorModuleFactory.getModuleName();
moduleDirAbsolute = currentCase.getModulesOutputDirAbsPath() + File.separator + ArchiveFileExtractorModuleFactory.getModuleName(); moduleDirAbsolute = currentCase.getModulesOutputDirAbsPath() + File.separator + ArchiveFileExtractorModuleFactory.getModuleName();

View File

@ -209,7 +209,7 @@ public final class RAImageIngestModule implements DataSourceIngestModule {
* @return Path to directory * @return Path to directory
*/ */
protected static String getRAOutputPath(Case a_case, String mod) { protected static String getRAOutputPath(Case a_case, String mod) {
String tmpDir = a_case.getModulesOutputDirAbsPath()+ File.separator + "RecentActivity" + File.separator + mod; //NON-NLS String tmpDir = a_case.getModulesOutputDirAbsPath() + File.separator + "RecentActivity" + File.separator + mod; //NON-NLS
File dir = new File(tmpDir); File dir = new File(tmpDir);
if (dir.exists() == false) { if (dir.exists() == false) {
dir.mkdirs(); dir.mkdirs();

View File

@ -1,5 +1,5 @@
#Updated by build script #Updated by build script
#Thu, 14 May 2015 16:14:51 -0400 #Tue, 28 Apr 2015 18:19:58 -0400
LBL_splash_window_title=Starting Autopsy LBL_splash_window_title=Starting Autopsy
SPLASH_HEIGHT=314 SPLASH_HEIGHT=314
SPLASH_WIDTH=538 SPLASH_WIDTH=538

View File

@ -1,5 +1,5 @@
#Updated by build script #Updated by build script
#Thu, 14 May 2015 16:14:51 -0400 #Tue, 28 Apr 2015 18:19:58 -0400
CTL_MainWindow_Title=Autopsy 3.1.2 CTL_MainWindow_Title=Autopsy 3.1.2
CTL_MainWindow_Title_No_Project=Autopsy 3.1.2 CTL_MainWindow_Title_No_Project=Autopsy 3.1.2

View File

@ -252,8 +252,8 @@ public final class ThunderbirdMboxFileIngestModule implements FileIngestModule {
} }
public static String getModuleOutputPath() { public static String getModuleOutputPath() {
String outDir = Case.getCurrentCase().getModulesOutputDirAbsPath() + String outDir = Case.getCurrentCase().getModulesOutputDirAbsPath() + File.separator
File.separator + EmailParserModuleFactory.getModuleName(); + EmailParserModuleFactory.getModuleName();
File dir = new File(outDir); File dir = new File(outDir);
if (dir.exists() == false) { if (dir.exists() == false) {
dir.mkdirs(); dir.mkdirs();
@ -262,8 +262,8 @@ public final class ThunderbirdMboxFileIngestModule implements FileIngestModule {
} }
public static String getRelModuleOutputPath() { public static String getRelModuleOutputPath() {
return Case.getCurrentCase().getModuleOutputDirectoryRelativePath() + return Case.getCurrentCase().getModulesOutputDirRelPath() + File.separator
File.separator + EmailParserModuleFactory.getModuleName(); + EmailParserModuleFactory.getModuleName();
} }
/** /**