Fixed semantics.

Core/src/org/sleuthkit/autopsy/filesearch/DateSearchFilter.java

@@ -205,19 +205,9 @@ class DateSearchFilter extends AbstractFileSearchFilter<DateSearchPanel> {
         getComponent().addActionListener(l);
     }
 
-    @Override
-    public void addPropertyChangeListener(PropertyChangeListener listener) {
-        getComponent().addPropertyChangeListener(listener);
-    }
-
     @Override
     public boolean isValid() {
-        if (!isEnabled()) {
+            return this.getComponent().isValidSearch();
-            return true;
-        }
-        else {
-            return this.getComponent().isSearchable();
-        }
     }
 
     /**

Core/src/org/sleuthkit/autopsy/filesearch/DateSearchPanel.java

@@ -430,7 +430,7 @@ class DateSearchPanel extends javax.swing.JPanel {
         dateToButtonCalendar.setTargetDate(date);
     }
     
-    boolean isSearchable() {
+    boolean isValidSearch() {
         return this.accessedCheckBox.isSelected() ||
                 this.changedCheckBox.isSelected() ||
                 this.createdCheckBox.isSelected() ||

Core/src/org/sleuthkit/autopsy/filesearch/FileSearchFilter.java

@@ -25,7 +25,7 @@ import javax.swing.JComponent;
 /**
  * Provides a filter and the panel to display it to the FileSearchTopComponent
  */
- interface FileSearchFilter {
+interface FileSearchFilter {
 
     /**
      * Gets the panel to put in the File Search pane.
@@ -41,6 +41,11 @@ import javax.swing.JComponent;
      */
     boolean isEnabled();
 
+    /**
+     * Checks if the panel has valid input for search.
+     *
+     * @return Whether the panel has valid input for search.
+     */
     boolean isValid();
 
     /**
@@ -59,6 +64,11 @@ import javax.swing.JComponent;
      */
     void addActionListener(ActionListener l);
 
+    /**
+     * Adds the property change listener to the panel
+     *
+     * @param listener the listener to add.
+     */
     void addPropertyChangeListener(PropertyChangeListener listener);
 
     /**

Core/src/org/sleuthkit/autopsy/filesearch/FileSearchPanel.java

@@ -105,7 +105,7 @@ class FileSearchPanel extends javax.swing.JPanel {
             filter.addPropertyChangeListener(new PropertyChangeListener() {
                 @Override
                 public void propertyChange(PropertyChangeEvent evt) {
-                    searchButton.setEnabled(isSearchable());
+                    searchButton.setEnabled(isValidSearch());
                 }
             });
         }
@@ -116,13 +116,13 @@ class FileSearchPanel extends javax.swing.JPanel {
                 search();
             }
         });
-        searchButton.setEnabled(isSearchable());
+        searchButton.setEnabled(isValidSearch());
     }
 
     /**
      * @return true if any of the filters in the panel are enabled (checked)
      */
-    private boolean isSearchable() {
+    private boolean isValidSearch() {
         boolean enabled = false;
         for (FileSearchFilter filter : this.getFilters()) {
             if (filter.isEnabled()) {
@@ -144,7 +144,7 @@ class FileSearchPanel extends javax.swing.JPanel {
         // change the cursor to "waiting cursor" for this operation
         this.setCursor(Cursor.getPredefinedCursor(Cursor.WAIT_CURSOR));
         try {
-            if (this.isSearchable()) {
+            if (this.isValidSearch()) {
                 String title = NbBundle.getMessage(this.getClass(), "FileSearchPanel.search.results.title", ++resultWindowCount);
                 String pathText = NbBundle.getMessage(this.getClass(), "FileSearchPanel.search.results.pathText");
 

Core/src/org/sleuthkit/autopsy/filesearch/KnownStatusSearchFilter.java

@@ -86,10 +86,6 @@ class KnownStatusSearchFilter extends AbstractFileSearchFilter<KnownStatusSearch
 
     @Override
     public boolean isValid() {
-        if (!isEnabled()) {
+            return this.getComponent().isValidSearch();
-            return true;
-        } else {
-            return this.getComponent().isSearchable();
-        }
     }
 }

Core/src/org/sleuthkit/autopsy/filesearch/KnownStatusSearchPanel.java

@@ -77,7 +77,7 @@ class KnownStatusSearchPanel extends javax.swing.JPanel {
         pcs.removePropertyChangeListener(pcl);
     }
 
-    boolean isSearchable() {
+    boolean isValidSearch() {
         return this.unknownOptionCheckBox.isSelected() || this.knownBadOptionCheckBox.isSelected() || this.knownOptionCheckBox.isSelected();
     }
 

Core/src/org/sleuthkit/autopsy/filesearch/MimeTypeFilter.java

@@ -43,10 +43,6 @@ class MimeTypeFilter extends AbstractFileSearchFilter<MimeTypePanel> {
 
     @Override
     public boolean isValid() {
-        if (!isEnabled()) {
+        return !this.getComponent().getMimeTypesSelected().isEmpty();
-            return true;
-        } else {
-            return !this.getComponent().getMimeTypesSelected().isEmpty();
-        }
     }
 }

Core/src/org/sleuthkit/autopsy/filesearch/NameSearchFilter.java

@@ -65,10 +65,6 @@ class NameSearchFilter extends AbstractFileSearchFilter<NameSearchPanel> {
 
     @Override
     public boolean isValid() {
-        if (!isEnabled()) {
+        return !this.getComponent().getSearchTextField().getText().isEmpty();
-            return true;
-        } else {
-            return !this.getComponent().getSearchTextField().getText().isEmpty();
-        }
     }
 }