mstoeck3/autopsy-flatpak
1
0
Fork 0
mirror of https://github.com/overcuriousity/autopsy-flatpak.git synced 2025-07-13 00:16:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Code review comments

Browse Source
This commit is contained in:
Eugene Livis 2017-10-23 16:28:52 -04:00
parent 5f9c5facce
commit 0451208df8
7 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Core/src/org/sleuthkit/autopsy/ingest/IngestMonitor.java
View File

@ -192,8 +192,6 @@ public final class IngestMonitor {
} }
logMemoryUsage(); logMemoryUsage();
//logDiskSpaceUsage(); // this creates a log entry every minute
if (!enoughDiskSpace()) { if (!enoughDiskSpace()) {
/* /*
* Shut down ingest by cancelling all ingest jobs. * Shut down ingest by cancelling all ingest jobs.

2
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/AddArchiveTask.java
View File

@ -34,7 +34,7 @@ import org.sleuthkit.datamodel.Content;
* A runnable that adds an archive data source as well as data sources * A runnable that adds an archive data source as well as data sources
* contained in the archive to the case database. * contained in the archive to the case database.
*/ */
public class AddArchiveTask implements Runnable { class AddArchiveTask implements Runnable {
private final Logger logger = Logger.getLogger(AddArchiveTask.class.getName()); private final Logger logger = Logger.getLogger(AddArchiveTask.class.getName());
private final String deviceId; private final String deviceId;

6
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/ArchiveExtractorDSProcessor.java
View File

@ -39,9 +39,11 @@ import org.sleuthkit.autopsy.datasourceprocessors.AutoIngestDataSourceProcessor;
// @ServiceProvider(service=DataSourceProcessor.class), // @ServiceProvider(service=DataSourceProcessor.class),
// @ServiceProvider(service=AutoIngestDataSourceProcessor.class)} // @ServiceProvider(service=AutoIngestDataSourceProcessor.class)}
//) //)
@NbBundle.Messages({
"ArchiveDSP.dsType.text=Archive file"})
public class ArchiveExtractorDSProcessor implements DataSourceProcessor, AutoIngestDataSourceProcessor { public class ArchiveExtractorDSProcessor implements DataSourceProcessor, AutoIngestDataSourceProcessor {
private final static String DATA_SOURCE_TYPE = NbBundle.getMessage(ArchiveExtractorDSProcessor.class, "ArchiveExtractorDataSourceProcessor.dsType.text"); private final static String DATA_SOURCE_TYPE = Bundle.ArchiveDSP_dsType_text();
private final ArchiveFilePanel configPanel; private final ArchiveFilePanel configPanel;
private String deviceId; private String deviceId;

2
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/ArchiveFilePanel.java
View File

@ -42,7 +42,7 @@ import org.sleuthkit.autopsy.coreutils.PathValidator;
* "zip", "rar", "arj", "7z", "7zip", "gzip, etc). Allows the user to select a * "zip", "rar", "arj", "7z", "7zip", "gzip, etc). Allows the user to select a
* file. * file.
*/ */
public class ArchiveFilePanel extends JPanel implements DocumentListener { class ArchiveFilePanel extends JPanel implements DocumentListener {
private static final Logger logger = Logger.getLogger(ArchiveFilePanel.class.getName()); private static final Logger logger = Logger.getLogger(ArchiveFilePanel.class.getName());
private static final String PROP_LAST_ARCHIVE_PATH = "LBL_LastImage_PATH"; //NON-NLS private static final String PROP_LAST_ARCHIVE_PATH = "LBL_LastImage_PATH"; //NON-NLS

2
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/AutoIngestManager.java
View File

@ -2316,7 +2316,7 @@ public final class AutoIngestManager extends Observable implements PropertyChang
Map<AutoIngestDataSourceProcessor, Integer> validDataSourceProcessorsMap; Map<AutoIngestDataSourceProcessor, Integer> validDataSourceProcessorsMap;
try { try {
// lookup all AutomatedIngestDataSourceProcessors and poll which ones are able to process the current data source // lookup all AutomatedIngestDataSourceProcessors and poll which ones are able to process the current data source
validDataSourceProcessorsMap = IdentifyDataSourceProcessors.getDataSourceProcessor(dataSource.getPath()); validDataSourceProcessorsMap = DataSourceProcessorUtility.getDataSourceProcessor(dataSource.getPath());
} catch (AutoIngestDataSourceProcessor.AutoIngestDataSourceProcessorException ex) { } catch (AutoIngestDataSourceProcessor.AutoIngestDataSourceProcessorException ex) {
SYS_LOGGER.log(Level.SEVERE, "Exception while determining best data source processor for {0}", dataSource.getPath()); SYS_LOGGER.log(Level.SEVERE, "Exception while determining best data source processor for {0}", dataSource.getPath());
// rethrow the exception. It will get caught & handled upstream and will result in AIM auto-pause. // rethrow the exception. It will get caught & handled upstream and will result in AIM auto-pause.

2
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/Bundle.properties
View File

@ -247,8 +247,6 @@ AutoIngestDashboard.prioritizeJobButton.toolTipText=Move the selected job to the
AutoIngestDashboard.prioritizeJobButton.text=Prioritize &Job AutoIngestDashboard.prioritizeJobButton.text=Prioritize &Job
AutoIngestDashboard.prioritizeCaseButton.toolTipText=Move all images associated with a case to top of Pending queue. AutoIngestDashboard.prioritizeCaseButton.toolTipText=Move all images associated with a case to top of Pending queue.
AutoIngestDashboard.prioritizeCaseButton.text=Prioritize &Case AutoIngestDashboard.prioritizeCaseButton.text=Prioritize &Case
ArchiveExtractorDataSourceProcessor.dsType.text=Archive file
ArchiveExtractorDataSourceProcessor.process.exception.text=Exception while trying to extract archive
ArchiveFilePanel.pathLabel.text=Browse for an archive file: ArchiveFilePanel.pathLabel.text=Browse for an archive file:
ArchiveFilePanel.browseButton.text=Browse ArchiveFilePanel.browseButton.text=Browse
ArchiveFilePanel.pathTextField.text= ArchiveFilePanel.pathTextField.text=

5
Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/IdentifyDataSourceProcessors.java → Experimental/src/org/sleuthkit/autopsy/experimental/autoingest/DataSourceProcessorUtility.java
View File

@ -29,7 +29,10 @@ import org.sleuthkit.autopsy.datasourceprocessors.AutoIngestDataSourceProcessor.
/** /**
* A utility class to find Data Source Processors * A utility class to find Data Source Processors
*/ */
class IdentifyDataSourceProcessors { class DataSourceProcessorUtility {
private DataSourceProcessorUtility() {
}
/** /**
* A utility method to find all Data Source Processors (DSP) that are able * A utility method to find all Data Source Processors (DSP) that are able